Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/46875 )
Change subject: build system: Replace Makefile with a call to use meson ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/flashrom/+/46875/1/Makefile File Makefile:
https://review.coreboot.org/c/flashrom/+/46875/1/Makefile@a800 PS1, Line 800: CONFIG_EVERYTHING
Does meson provide a similar thing?
This should be fine with https://mesonbuild.com/Build-options.html#using-build-options ?
https://review.coreboot.org/c/flashrom/+/46875/1/Makefile@a1573 PS1, Line 1573: define NI845X_TEST
Does meson do these tests?
I would imagine so as its asking pkg-config if the headers and the library are properly installed. They should be pretty easy to add if required via custom_target of sort?
https://review.coreboot.org/c/flashrom/+/46875/1/Makefile@a1708 PS1, Line 1708: tarball: _export : @tar -cj --format=ustar -f "$(EXPORTDIR)/flashrom-$(RELEASENAME).tar.bz2" -C $(EXPORTDIR)/ \ : $(TAROPTIONS) "flashrom-$(RELEASENAME)/" : # Delete the exported directory again because it is most likely what's expected by the user. : @rm -rf "$(EXPORTDIR)/flashrom-$(RELEASENAME)" : @echo Created "$(EXPORTDIR)/flashrom-$(RELEASENAME).tar.bz2"
Does meson provide this?
https://mesonbuild.com/Creating-releases.html
This should work fine with an invocation of `$ meson dist`