View Change

3 comments:

• File Makefile:

  • Patch Set #1, Line 800: CONFIG_EVERYTHING

    Does meson provide a similar thing?

    This should be fine with https://mesonbuild.com/Build-options.html#using-build-options ?

  • Patch Set #1, Line 1573: define NI845X_TEST

    Does meson do these tests?

    I would imagine so as its asking pkg-config if the headers and the library are properly installed. They should be pretty easy to add if required via custom_target of sort?

  • Patch Set #1, Line 1708:

    tarball: _export
    	@tar -cj --format=ustar -f "$(EXPORTDIR)/flashrom-$(RELEASENAME).tar.bz2" -C $(EXPORTDIR)/ \
    		$(TAROPTIONS) "flashrom-$(RELEASENAME)/"
    #	Delete the exported directory again because it is most likely what's expected by the user.
    	@rm -rf "$(EXPORTDIR)/flashrom-$(RELEASENAME)"
    	@echo Created "$(EXPORTDIR)/flashrom-$(RELEASENAME).tar.bz2"
    

    Does meson provide this?

    https://mesonbuild.com/Creating-releases.html

    This should work fine with an invocation of `$ meson dist`

To view, visit change 46875. To unsubscribe, or for help writing mail filters, visit settings.