Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/44879 )
Change subject: support variable-size SPI chip for dummy programmer ......................................................................
Patch Set 6: Code-Review+2
(3 comments)
https://review.coreboot.org/c/flashrom/+/44879/6/dummyflasher.c File dummyflasher.c:
https://review.coreboot.org/c/flashrom/+/44879/6/dummyflasher.c@917 PS6, Line 917: int unsigned i;
https://review.coreboot.org/c/flashrom/+/44879/6/dummyflasher.c@938 PS6, Line 938: pdate eraser count * "Update the first count of each of the block_erasers" or something more detailed why here.
https://review.coreboot.org/c/flashrom/+/44879/6/dummyflasher.c@941 PS6, Line 941: eraser->block_erase == NULL `if (!eraser->block_erase)` is canonical