Attention is currently required from: Thomas Heijligen, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61276 )
Change subject: hwaccess_x86_io: clean header concept ......................................................................
Patch Set 11: Code-Review+1
(6 comments)
File hwaccess_x86_io.c:
https://review.coreboot.org/c/flashrom/+/61276/comment/be3a0bf6_887e3aeb PS7, Line 36: * functions. `platform_get_io_perms()` is called to get
Done
There are two more in the lines above.
File hwaccess_x86_io.c:
https://review.coreboot.org/c/flashrom/+/61276/comment/5c235b40_796de1fc PS11, Line 48: define USE_LIBC_LAST 1 : #define USE_LIBC_FIRST 2 Without the target/destination part, this is far from selfexplanatory.
https://review.coreboot.org/c/flashrom/+/61276/comment/836e6d7d_18075118 PS11, Line 58: USEIOPERM Missing underscore.
https://review.coreboot.org/c/flashrom/+/61276/comment/2026fffc_8e4d887d PS11, Line 123: 1 Leftover?
https://review.coreboot.org/c/flashrom/+/61276/comment/bbe17bf4_5db57a74 PS11, Line 146: Maybe to catch some typos: ``` #if IO_PORT_PERMISSION == 0 || IO_PORT_FUNCTION == 0 #error Unsupported or misconfigured platform. #endif ``` (Undefined identifiers evaluate to 0 when used with relational operators.)
https://review.coreboot.org/c/flashrom/+/61276/comment/4e2a8af1_775c7ddd PS11, Line 322: Missing line break.