Attention is currently required from: Thomas Heijligen, Angel Pons.

Patch set 11:Code-Review +1

View Change

6 comments:

• File hwaccess_x86_io.c:

  • Patch Set #7, Line 36: * functions. `platform_get_io_perms()` is called to get

    Done

    There are two more in the lines above.

• File hwaccess_x86_io.c:

  • Patch Set #11, Line 48:

    define USE_LIBC_LAST	1
    #define USE_LIBC_FIRST	2
    

    Without the target/destination part, this is far from selfexplanatory.

  • Patch Set #11, Line 58: USEIOPERM

    Missing underscore.

  • Patch Set #11, Line 123: 1

    Leftover?

  • Patch Set #11, Line 146:

    Maybe to catch some typos:
    ```
    #if IO_PORT_PERMISSION == 0 || IO_PORT_FUNCTION == 0
    #error Unsupported or misconfigured platform.
    #endif
    ```
    (Undefined identifiers evaluate to 0 when used with relational operators.)

  • Patch Set #11, Line 322:

    Missing line break.

To view, visit change 61276. To unsubscribe, or for help writing mail filters, visit settings.