Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35592 )
Change subject: cli_classic: Add convenient '--get-size' cli opt ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/flashrom/+/35592/5/cli_classic.c File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/35592/5/cli_classic.c@137 PS5, Line 137: {"get-size", 0, NULL, OPTION_GET_SIZE},
Bike-shedding: Maybe this should be named "flash-size"? That will go better with "flash-name", I thi […]
This would create a lot of frustration dealing with retooling chromiumos to handle two flashroms with different argument conventions for essentially no gain beyond the subjective. --help gives the user the option so it's not a huge deal.
https://review.coreboot.org/c/flashrom/+/35592/5/cli_classic.c@315 PS5, Line 315: "specified. Aborting.\n");
Should fit on one line?
Maybe but that is a style change that touches the convention of other options that do the same so would just introduce inconsistencies and/or scope run-away for this patch. I rather keep the patch to the point.