View Change

2 comments:

• File cli_classic.c:

  • Patch Set #5, Line 137: {"get-size", 0, NULL, OPTION_GET_SIZE},

    Bike-shedding: Maybe this should be named "flash-size"? That will go better with "flash-name", I thi […]

    This would create a lot of frustration dealing with retooling chromiumos to handle two flashroms with different argument conventions for essentially no gain beyond the subjective. --help gives the user the option so it's not a huge deal.

  • Patch Set #5, Line 315: "specified. Aborting.\n");

    Should fit on one line?

    Maybe but that is a style change that touches the convention of other options that do the same so would just introduce inconsistencies and/or scope run-away for this patch. I rather keep the patch to the point.

To view, visit change 35592. To unsubscribe, or for help writing mail filters, visit settings.