Attention is currently required from: Edward O'Callaghan, Felix Singer, Nico Huber, Angel Pons, Michael Niewöhner.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/60055 )
Change subject: SFDP: drop static table length check to make newer SFDP revisions work
......................................................................
Patch Set 2:
(2 comments)
File sfdp.c:
https://review.coreboot.org/c/flashrom/+/60055/comment/f8ac5ed6_451c9bdb
PS2, Line 133: msg_cdbg("Parsing JEDEC flash parameter table... ");
: msg_cdbg2("\n");
Looks like these two message can be merged into one now. It is not very clear why first one is cdbg and second (which is just a new line) is cdbg2?
Since this is now only informational, not an error message, that's probably cdbg2?
https://review.coreboot.org/c/flashrom/+/60055/comment/b84834da_af35021d
PS2, Line 372: } else if (sfdp_fill_flash(flash->chip, tbuf, len) == 0)
Oh so length of table was checked twice?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/60055
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id84cde4ebc805d68e2984e8041fbc48d7ceebe34
Gerrit-Change-Number: 60055
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
edward.ocallaghan@koparo.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Edward O'Callaghan
edward.ocallaghan@koparo.com
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Sun, 09 Jan 2022 23:22:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment