Attention is currently required from: Edward O'Callaghan, Felix Singer, Nico Huber, Angel Pons, Michael Niewöhner.

View Change

2 comments:

• File sfdp.c:

  • Patch Set #2, Line 133:

    	msg_cdbg("Parsing JEDEC flash parameter table... ");
    	msg_cdbg2("\n");
    

    Looks like these two message can be merged into one now. It is not very clear why first one is cdbg and second (which is just a new line) is cdbg2?
    Since this is now only informational, not an error message, that's probably cdbg2?

  • Patch Set #2, Line 372: } else if (sfdp_fill_flash(flash->chip, tbuf, len) == 0)

    Oh so length of table was checked twice?

To view, visit change 60055. To unsubscribe, or for help writing mail filters, visit settings.