Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer.
Hsuan-ting Chen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/78348?usp=email )
Change subject: flashchips: Split GD25Q127C/GD25Q128C and add GD25Q128E
......................................................................
Patch Set 3:
(1 comment)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/78348/comment/27bcd5ca_403a16fe :
PS1, Line 6802: /* FIXME: 128E's OTP: 3072B total and doesn't support QPI */
- Yes, I think you need to separate the two chip definitions. […]
Sure, then let's go for `128C` and `127C/128E`.
Thanks for the clarification.
I saw the comment shows `can be distinguished by SFDP` does that mean `flashrom` is able to distinguish them? Or is it impossible and we still need to add `-c` manually?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/78348?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I3300671b1cf74b3ea0469b9c5a833489ab4914f5
Gerrit-Change-Number: 78348
Gerrit-PatchSet: 3
Gerrit-Owner: Hsuan-ting Chen
roccochen@google.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Mon, 30 Oct 2023 08:03:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hsuan-ting Chen
roccochen@google.com
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment
