Paul Kocialkowski has posted comments on this change. ( https://review.coreboot.org/23261 )
Change subject: ENE EDI - print debug info like others while probing for ENE chips ......................................................................
Patch Set 5:
(3 comments)
Thanks for the work! We're getting there :)
https://review.coreboot.org/#/c/23261/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/23261/5//COMMIT_MSG@7 PS5, Line 7: ENE EDI - print debug info like others while probing for ENE chips Like with the other commit, is that the regular way to prefix commits in flashrom?
I suggest "edi: Print debug info like others while probing for ENE chips" instead.
https://review.coreboot.org/#/c/23261/5/edi.c File edi.c:
https://review.coreboot.org/#/c/23261/5/edi.c@154 PS5, Line 154: msg_cdbg("%s: reading HWVERSION failed\n", __func__); Please use lowercase so that it's consistent with the message printed on success.
https://review.coreboot.org/#/c/23261/5/edi.c@160 PS5, Line 160: msg_cdbg("%s: reading EDIID failed\n", __func__); ditto