Thanks for the work! We're getting there :)

View Change

3 comments:

• Commit Message:

  • Patch Set #5, Line 7: ENE EDI - print debug info like others while probing for ENE chips

    Like with the other commit, is that the regular way to prefix commits in flashrom?

    I suggest "edi: Print debug info like others while probing for ENE chips" instead.

• File edi.c:

  • Patch Set #5, Line 154: msg_cdbg("%s: reading HWVERSION failed\n", __func__);

    Please use lowercase so that it's consistent with the message printed on success.

  • Patch Set #5, Line 160: msg_cdbg("%s: reading EDIID failed\n", __func__);

    ditto

To view, visit change 23261. To unsubscribe, or for help writing mail filters, visit settings.