Ryan O'Leary has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34160 ) Change subject: dediprog.c: Add id parameter to dediprog programmer ...................................................................... Patch Set 5: (1 comment) https://review.coreboot.org/c/flashrom/+/34160/4/dediprog.c File dediprog.c: https://review.coreboot.org/c/flashrom/+/34160/4/dediprog.c@1206 PS4, Line 1206: if (id != -1) {
This is always true, right? `id` can't have changed since we checked this in […] Yes, my mistake. Fixed!
-- To view, visit https://review.coreboot.org/c/flashrom/+/34160 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I4281213ab02131feb5d47bf66118a001cec0d219 Gerrit-Change-Number: 34160 Gerrit-PatchSet: 5 Gerrit-Owner: Ryan O'Leary <ryanoleary@google.com> Gerrit-Assignee: Ryan O'Leary <ryanoleary@google.com> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Ryan O'Leary <ryanoleary@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Reviewer: ron minnich <rminnich@gmail.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Wed, 13 Nov 2019 17:45:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h@gmx.de> Gerrit-MessageType: comment