Nico Huber has posted comments on this change. ( https://review.coreboot.org/21830 )
Change subject: fixup! Convert flashrom to git ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/21830/1/Makefile File Makefile:
https://review.coreboot.org/#/c/21830/1/Makefile@a544 PS1, Line 544: Why drop the empty line? anyway the whole block seems to be a dead artifact. getrevsion.sh never returns "offline", does it?
https://review.coreboot.org/#/c/21830/1/Makefile@529 PS1, Line 529: required by the build process when packaging flashrom This is not true, AFAIU (the old text wasn't very accurate either). It is not required "by the build process when packaging flashrom" but "to build a packaged flashrom"?