Nico Huber posted comments on this change.
View Change
Patch set 1:
(2 comments)
File Makefile:
Patch Set #1, Line 544:
Why drop the empty line? anyway the whole block seems to be a dead
artifact. getrevsion.sh never returns "offline", does it?
Patch Set #1, Line 529: required by the build process when packaging flashrom
This is not true, AFAIU (the old text wasn't very accurate either).
It is not required "by the build process when packaging flashrom"
but "to build a packaged flashrom"?
To view, visit change 21830. To unsubscribe, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c66f2508cc754cf9219211a06d6f305a32c422d
Gerrit-Change-Number: 21830
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Tauner <stefan.tauner@gmx.at>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Mon, 02 Oct 2017 12:38:05 +0000
Gerrit-HasComments: Yes