Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56501 )
Change subject: tests: Add tests to erase a chip ......................................................................
Patch Set 4:
(2 comments)
File tests/chip.c:
https://review.coreboot.org/c/flashrom/+/56501/comment/6d59786e_a1590474 PS3, Line 26: chip_state
g_chip_state
Done
https://review.coreboot.org/c/flashrom/+/56501/comment/6ad66b93_689b209b PS3, Line 37: /* : * Populate buf with the value used for erase operation, this allows to pass : * verification checks and also emulates successful erase. : */ : buf = memset(buf, 0xff, len);
this should be coming from the chip state now
Done. I am sorry I misunderstood your comment before. Thought it was done after adding second test which uses dummy's emulation capabilities, because dummy keeps state etc. But of course, improving first test is a good idea. Thank you for helping me with this!