Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons.
View Change
2 comments:
File tests/chip.c:
Patch Set #3, Line 26: chip_state
g_chip_state
Done
Patch Set #3, Line 37:
/*
* Populate buf with the value used for erase operation, this allows to pass
* verification checks and also emulates successful erase.
*/
buf = memset(buf, 0xff, len);
this should be coming from the chip state now
Done.
I am sorry I misunderstood your comment before. Thought it was done after adding second test which uses dummy's emulation capabilities, because dummy keeps state etc.
But of course, improving first test is a good idea. Thank you for helping me with this!
To view, visit change 56501. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6f74bfe4e02244d24d6c837cc3d551251e7b4898
Gerrit-Change-Number: 56501
Gerrit-PatchSet: 4
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Tue, 27 Jul 2021 04:27:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-MessageType: comment