Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/39965 )
Change subject: pcidev: On arm64 we are not getting a valid BAR0 address ......................................................................
Patch Set 4: Code-Review+1
(3 comments)
https://review.coreboot.org/c/flashrom/+/39965/4/pcidev.c File pcidev.c:
https://review.coreboot.org/c/flashrom/+/39965/4/pcidev.c@33 PS4, Line 33: int pci_bar_number_from_offset(int offset) I'd make this static
https://review.coreboot.org/c/flashrom/+/39965/4/pcidev.c@48 PS4, Line 48: default: : return -1; : } : return -1; One of these return statements is redundant
https://review.coreboot.org/c/flashrom/+/39965/4/pcidev.c@60 PS4, Line 60: bar_number bar_index?