Patch set 4:Code-Review +1

View Change

3 comments:

• File pcidev.c:

  • Patch Set #4, Line 33: int pci_bar_number_from_offset(int offset)

    I'd make this static

  • Patch Set #4, Line 48:

    default:
    			return -1;
    	}
    	return -1;
    

    One of these return statements is redundant

  • Patch Set #4, Line 60: bar_number

    bar_index?

To view, visit change 39965. To unsubscribe, or for help writing mail filters, visit settings.