Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47090 )
Change subject: chipset_enable.c: Add Intel pch7 did=0x1e4{1,2,3} support
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/flashrom/+/47090/2/chipset_enable.c
File chipset_enable.c:
https://review.coreboot.org/c/flashrom/+/47090/2/chipset_enable.c@1841
PS2, Line 1841: enable_flash_pch6
enable_flash_pch7
Done
https://review.coreboot.org/c/flashrom/+/47090/2/chipset_enable.c@1841
PS2, Line 1841: Desktop Full
It would be nice to use "Desktop Sample", "Mobile Sample" and "SFF Sample" to match coreboot: […]
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/47090
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ic69dc024e9af0c43d6b3a8213a5dc5d2f898c447
Gerrit-Change-Number: 47090
Gerrit-PatchSet: 4
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 14 Nov 2020 03:26:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sam McNally
sammc@google.com
Gerrit-MessageType: comment