Attention is currently required from: Felix Singer, Michał Żygowski, Paul Menzel, Sergii Dmytruk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55715 )
Change subject: ite_ecfw: Implement support for flashing ITE ECs found on TUXEDO laptops ......................................................................
Patch Set 29:
(2 comments)
Patchset:
PS29: Not sure if it was mentioned before: Generally smaller patches are preferred. Review doesn't scale well with the amount of lines and commit messages tend to be far too thin. With 10 10-times smaller patches, I generally expect 10-times faster review compared to everything at once. This one would be hard to split that much, but there are still ~4 independent topics here: board checking, flashing, content compatibilty checking (does it belong in flashrom?), the autoload option (does it belong in flashrom?).
Don't know if it's too late to split.
File ite_ecfw.c:
https://review.coreboot.org/c/flashrom/+/55715/comment/93e4c8dd_2d3fa31d PS29, Line 411: } Doesn't this mean we always have to flash the whole chip? and all blocks in order? Should we set the write granularity to the flash size in this case?