Attention is currently required from: Felix Singer, Michał Żygowski, Paul Menzel, Sergii Dmytruk.

View Change

2 comments:

• Patchset:

  • Patch Set #29:

    Not sure if it was mentioned before: Generally smaller patches
    are preferred. Review doesn't scale well with the amount of lines
    and commit messages tend to be far too thin. With 10 10-times
    smaller patches, I generally expect 10-times faster review
    compared to everything at once. This one would be hard to split
    that much, but there are still ~4 independent topics here:
    board checking, flashing, content compatibilty checking (does it
    belong in flashrom?), the autoload option (does it belong in
    flashrom?).

    Don't know if it's too late to split.

• File ite_ecfw.c:

  • Patch Set #29, Line 411: }

    Doesn't this mean we always have to flash the whole chip? and all blocks in
    order? Should we set the write granularity to the flash size in this case?

To view, visit change 55715. To unsubscribe, or for help writing mail filters, visit settings.