Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33518 )
Change subject: layout: Introduce layout_next_included()
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/33518/1/layout.c
File layout.c:
https://review.coreboot.org/#/c/33518/1/layout.c@246
PS1, Line 246:
: for (i = 0; i < layout->num_entries; ++i) {
: if (!layout->entries[i].included)
: continue;
: if (!iterator)
: return &layout->entries[i];
: if (iterator == &layout->entries[i])
: iterator = NULL;
: }
This will result in an endless while-loop that is calling this if there are duplicate entries in the layout. Do we guard against that somewhere?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/33518
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib01c8af06c3f84eafbd585760e74c3c287b9fa7d
Gerrit-Change-Number: 33518
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 16 Jun 2019 07:18:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment