Attention is currently required from: Felix Singer, Alexander Goncharov.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68247 )
Change subject: util: add bash completion script ......................................................................
Patch Set 9: Code-Review+1
(3 comments)
File Makefile:
https://review.coreboot.org/c/flashrom/+/68247/comment/e0dc52d7_29d87f82 PS9, Line 1041: .bash IIRC there should be no `.bash` suffix
File meson.build:
https://review.coreboot.org/c/flashrom/+/68247/comment/03a7a3c0_be91b777 PS9, Line 624: if get_option('classic_cli').disabled() When `get_option('bash_completion').auto()` and `get_option('classic_cli').disabled()` are true, there should be no action.
`get_option('bash_completion').auto()` equals `get_option('classic_cli').auto()` in the behavior. So if I disable the cli, the bash_completion is also disabled.
https://review.coreboot.org/c/flashrom/+/68247/comment/5bd340f3_7da26838 PS9, Line 646: .bash same here