Attention is currently required from: Felix Singer, Alexander Goncharov.

Patch set 9:Code-Review +1

View Change

3 comments:

• File Makefile:

  • Patch Set #9, Line 1041: .bash

    IIRC there should be no `.bash` suffix

• File meson.build:

  • Patch Set #9, Line 624: if get_option('classic_cli').disabled()

    When `get_option('bash_completion').auto()` and `get_option('classic_cli').disabled()` are true, there should be no action.

    `get_option('bash_completion').auto()` equals `get_option('classic_cli').auto()` in the behavior. So if I disable the cli, the bash_completion is also disabled.

  • Patch Set #9, Line 646: .bash

    same here

To view, visit change 68247. To unsubscribe, or for help writing mail filters, visit settings.