[flashrom-gerrit] [S] Change in flashrom[1.2.x]: dediprog: Fix segmentation fault on no device found

[Nico Huber (Code Review)]

Attention is currently required from: Medicine Yeh, Stefan Reinauer, Edward O'Callaghan, Angel Pons.

Hello build bot (Jenkins), Medicine Yeh, Stefan Reinauer, Edward O'Callaghan, Angel Pons,

I'd like you to do a code review.
Please visit

https://review.coreboot.org/c/flashrom/+/67869

to review the following change.

Change subject: dediprog: Fix segmentation fault on no device found
......................................................................

dediprog: Fix segmentation fault on no device found

libusb_exit() call is done by dediprog_open() under the
ret == 1 condition. Removing this line has no impact on
any flow and side effect of the program.

Change-Id: I38b3f3ee3f9d46845df1404791f4a4782320aa7c
Signed-off-by: Medicine Yeh 
Reviewed-on: https://review.coreboot.org/c/flashrom/+/48688
Reviewed-by: Angel Pons 
Reviewed-by: Edward O'Callaghan 
Reviewed-by: Stefan Reinauer 
Tested-by: build bot (Jenkins) 
---
M dediprog.c
1 file changed, 19 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/69/67869/1

diff --git a/dediprog.c b/dediprog.c
index 175e099..99df7b0 100644
--- a/dediprog.c
+++ b/dediprog.c
@@ -1188,7 +1188,6 @@
    		ret = dediprog_open(i);
    		if (ret == -1) {
    			/* no dev */
-				libusb_exit(usb_ctx);
    			return 1;
    		} else if (ret == -2) {
    			/* busy dev */