Attention is currently required from: Medicine Yeh, Stefan Reinauer, Edward O'Callaghan, Angel Pons.
Nico Huber would like build bot (Jenkins), Medicine Yeh, Stefan Reinauer, Edward O'Callaghan and Angel Pons to review this change.
dediprog: Fix segmentation fault on no device found
libusb_exit() call is done by dediprog_open() under the
ret == 1 condition. Removing this line has no impact on
any flow and side effect of the program.
Change-Id: I38b3f3ee3f9d46845df1404791f4a4782320aa7c
Signed-off-by: Medicine Yeh <medicinehy@gmail.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/48688
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M dediprog.c
1 file changed, 19 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/69/67869/1
diff --git a/dediprog.c b/dediprog.c
index 175e099..99df7b0 100644
--- a/dediprog.c
+++ b/dediprog.c
@@ -1188,7 +1188,6 @@
ret = dediprog_open(i);
if (ret == -1) {
/* no dev */
- libusb_exit(usb_ctx);
return 1;
} else if (ret == -2) {
/* busy dev */
To view, visit change 67869. To unsubscribe, or for help writing mail filters, visit settings.