Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40325 )
Change subject: Add writeprotect support infrastructure ......................................................................
Patch Set 11:
(6 comments)
https://review.coreboot.org/c/flashrom/+/40325/6/cli_classic.c File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/40325/6/cli_classic.c@718 PS6, Line 718: start = strtoul(argv[optind], &endptr, 0); : if (errno == ERANGE || errno == EINVAL || *endptr != '\0') { : msg_gerr("Error: value "%s" invalid\n", argv[optind]); : ret = 1; : goto out_shutdown; : } : : len = strtoul(argv[optind + 1], &endptr, 0); : if (errno == ERANGE || errno == EINVAL || *endptr != '\0') { : msg_gerr("Error: value "%s" invalid\n", argv[optind + 1]);
I purpose the following downstream: […]
Ack
https://review.coreboot.org/c/flashrom/+/40325/2/writeprotect.c File writeprotect.c:
https://review.coreboot.org/c/flashrom/+/40325/2/writeprotect.c@15 PS2, Line 15: *
empty line in comment
Ack
https://review.coreboot.org/c/flashrom/+/40325/2/writeprotect.c@140 PS2, Line 140: struct wp_range_descriptor en25f40_ranges[] = {
Well, that would be nice as well. […]
Ack
https://review.coreboot.org/c/flashrom/+/40325/6/writeprotect.c File writeprotect.c:
https://review.coreboot.org/c/flashrom/+/40325/6/writeprotect.c@851 PS6, Line 851: /* FIXME: Move to spi25.c if it's a JEDEC standard opcode */
Should this fn be moved?
Done
https://review.coreboot.org/c/flashrom/+/40325/6/writeprotect.c@872 PS6, Line 872: /* FIXME: Move to spi25.c if it's a JEDEC standard opcode */
Ditto
Done
https://review.coreboot.org/c/flashrom/+/40325/7/writeprotect.c File writeprotect.c:
https://review.coreboot.org/c/flashrom/+/40325/7/writeprotect.c@1473 PS7, Line 1473: /* FIXME: this is NOT endian-free copy. */
I have moved the winbond support into a follow up commit to deal with it separately from the wp infr […]
Ack