View Change

6 comments:

• File cli_classic.c:

  • Patch Set #6, Line 718:

    		start = strtoul(argv[optind], &endptr, 0);
    		if (errno == ERANGE || errno == EINVAL || *endptr != '\0') {
    			msg_gerr("Error: value \"%s\" invalid\n", argv[optind]);
    			ret = 1;
    			goto out_shutdown;
    		}
    
    		len = strtoul(argv[optind + 1], &endptr, 0);
    		if (errno == ERANGE || errno == EINVAL || *endptr != '\0') {
    			msg_gerr("Error: value \"%s\" invalid\n", argv[optind + 1]);
    

    I purpose the following downstream: […]

    Ack

• File writeprotect.c:

  • Patch Set #2, Line 15: *

    empty line in comment

    Ack

  • Patch Set #2, Line 140: struct wp_range_descriptor en25f40_ranges[] = {

    Well, that would be nice as well. […]

    Ack

• File writeprotect.c:

  • Patch Set #6, Line 851: /* FIXME: Move to spi25.c if it's a JEDEC standard opcode */

    Should this fn be moved?

    Done

  • Patch Set #6, Line 872: /* FIXME: Move to spi25.c if it's a JEDEC standard opcode */

    Ditto

    Done

• File writeprotect.c:

  • Patch Set #7, Line 1473: /* FIXME: this is NOT endian-free copy. */

    I have moved the winbond support into a follow up commit to deal with it separately from the wp infr […]

    Ack

To view, visit change 40325. To unsubscribe, or for help writing mail filters, visit settings.