[flashrom-gerrit] Change in flashrom[master]: Add support for Intel Emmitsburg PCH

[Nico Huber (Code Review)]

Attention is currently required from: Jonathan Zhang.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54965 )

Change subject: Add support for Intel Emmitsburg PCH
......................................................................

Patch Set 3:

(2 comments)

Patchset:

PS1:
> Yes, and IMO we should find a better heuristic or require the user to specify a ICH/PCH generation o […]

I'm not talking about the detection. I mean if anybody checked that
all the code activated by this patch matches the hardware and descriptor.
IOW if all the paths chosen for CHIPSET_C620_SERIES_LEWISBURG are
suitable or just work by chance for rudimentary flashing.

Now that I looked at the merged change, it seems obvious that it breaks
Ibex Peak detection. Its SPI guide is 403598. I'm not sure if Intel still
keeps these files.

File ich_descriptors.c:

https://review.coreboot.org/c/flashrom/+/54965/comment/7e85bdc5_740ff3f3 
PS3, Line 943: 			return CHIPSET_C620_SERIES_LEWISBURG;
Was this reviewed at all? It assumes that CHIPSET_5_SERIES_IBEX_PEAK
has ISL > 80. Which seems unlikely given the low numbers around here.

In the one descriptor file I have around ISL is 16.