Attention is currently required from: Jonathan Zhang.

View Change

2 comments:

• Patchset:

  • Patch Set #1:

    Yes, and IMO we should find a better heuristic or require the user to specify a ICH/PCH generation o […]

    I'm not talking about the detection. I mean if anybody checked that
    all the code activated by this patch matches the hardware and descriptor.
    IOW if all the paths chosen for CHIPSET_C620_SERIES_LEWISBURG are
    suitable or just work by chance for rudimentary flashing.

    Now that I looked at the merged change, it seems obvious that it breaks
    Ibex Peak detection. Its SPI guide is 403598. I'm not sure if Intel still
    keeps these files.

• File ich_descriptors.c:

  • Patch Set #3, Line 943: return CHIPSET_C620_SERIES_LEWISBURG;

    Was this reviewed at all? It assumes that CHIPSET_5_SERIES_IBEX_PEAK
    has ISL > 80. Which seems unlikely given the low numbers around here.

    In the one descriptor file I have around ISL is 16.

To view, visit change 54965. To unsubscribe, or for help writing mail filters, visit settings.