[flashrom-gerrit] Change in flashrom[master]: bitbang_spi: Add half-duplex optimizations

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/26947 )

Change subject: bitbang_spi: Add half-duplex optimizations
......................................................................

Patch Set 2: Code-Review+1

(2 comments)

https://review.coreboot.org/#/c/26947/2/bitbang_spi.c
File bitbang_spi.c:

https://review.coreboot.org/#/c/26947/2/bitbang_spi.c@128
PS2, Line 128: 		if (i == 0)
             : 			bitbang_spi_set_sck_set_mosi(master, 0, 0);
             : 		else
             : 			bitbang_spi_set_sck(master, 0);
I wouldn't expect the state of MOSI to matter. Though, I never read
the SPI specification. Is this defined somewhere?

https://review.coreboot.org/#/c/26947/2/bitbang_spi.c@141
PS2, Line 141: 				   uint8_t val)
Nit, we have a 112 chars line limit, so no line break needed here.