Patch set 2:Code-Review +1

View Change

2 comments:

• File bitbang_spi.c:

  • Patch Set #2, Line 128:

    		if (i == 0)
    			bitbang_spi_set_sck_set_mosi(master, 0, 0);
    		else
    			bitbang_spi_set_sck(master, 0);
    

    I wouldn't expect the state of MOSI to matter. Though, I never read
    the SPI specification. Is this defined somewhere?

  • Patch Set #2, Line 141: uint8_t val)

    Nit, we have a 112 chars line limit, so no line break needed here.

To view, visit change 26947. To unsubscribe, or for help writing mail filters, visit settings.