David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34363 )
Change subject: libflashrom: add querying functions with meson integration
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Looks good to me, I'm just wondering if flashrom_data_free() is needed.
https://review.coreboot.org/c/flashrom/+/34363/2/libflashrom.c
File libflashrom.c:
https://review.coreboot.org/c/flashrom/+/34363/2/libflashrom.c@233
PS2, Line 233: int flashrom_data_free(void *const p)
Do you really need this function? free()'ing NULL is a valid noop (https://pubs.opengroup.org/onlinepubs/009695399/functions/free.html)
--
To view, visit
https://review.coreboot.org/c/flashrom/+/34363
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I49041b8fa5700dabe59fef0d2337339d34cd6c6f
Gerrit-Change-Number: 34363
Gerrit-PatchSet: 2
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: ?ukasz Dmitrowski
lukasz.dmitrowski@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Mario Limonciello
superm1@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 06 Sep 2019 22:12:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment