Looks good to me, I'm just wondering if flashrom_data_free() is needed.

Patch set 2:Code-Review +1

View Change

1 comment:

• File libflashrom.c:

  • Patch Set #2, Line 233: int flashrom_data_free(void *const p)

    Do you really need this function? free()'ing NULL is a valid noop (https://pubs.opengroup.org/onlinepubs/009695399/functions/free.html)

To view, visit change 34363. To unsubscribe, or for help writing mail filters, visit settings.