Attention is currently required from: Felix Singer, Nico Huber, Thomas Heijligen, Alexander Goncharov.
Jean THOMAS has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67878 )
Change subject: dirtyjtag: Add DirtyJTAG programmer ......................................................................
Patch Set 7:
(5 comments)
Patchset:
PS7:
Thanks for your update. Alas, I missed to check the resource usage/cleanup in […]
Done
PS7: Hi Nico, don't worry and thanks again for your careful review. I tried addressing the cleanup issues and did a little bit of code styling to better match the requirements of the linux kernel coding style.
We're close to the end! ;-)
File dirtyjtag_spi.c:
https://review.coreboot.org/c/flashrom/+/67878/comment/cb86c88a_3f69e8d5 PS7, Line 154: 32
Just curious, is there anything in the last two bytes?
Nope! But the xfer reply is fixed 32 bytes, no matter how much data is written.
https://github.com/jeanthom/DirtyJTAG/blob/master/src/cmd.c#L179
https://review.coreboot.org/c/flashrom/+/67878/comment/cafac22d_a05dd3cd PS7, Line 212: NULL
Should use the `djtag_data->libusb_ctx`. Many more below, too.
Done
https://review.coreboot.org/c/flashrom/+/67878/comment/b1eafeb2_9ffcea8e PS7, Line 297: return -1;
Sorry, I always forget to check such cleanup paths ._. […]
Don't worry, I should've been more careful on this one. I've created 2 additionals labels for the cleanup path: * cleanup_djtag_struct: Freeing the djtag_data structure * cleanup_libusb_ctx: Cleaning the libusb context * cleanup_libusb_handle: Cleaning the libusb handle/attaching back the kernel driver