Attention is currently required from: Felix Singer, Nico Huber, Thomas Heijligen, Alexander Goncharov.

5 comments:

Patchset:
- Patch Set #7:
  Thanks for your update. Alas, I missed to check the resource usage/cleanup in […]
  Done
- Patch Set #7:
  Hi Nico, don't worry and thanks again for your careful review. I tried addressing the cleanup issues and did a little bit of code styling to better match the requirements of the linux kernel coding style.
  We're close to the end! ;-)
File dirtyjtag_spi.c:
- Patch Set #7, Line 154: 32
  Just curious, is there anything in the last two bytes?
  Nope! But the xfer reply is fixed 32 bytes, no matter how much data is written.
  https://github.com/jeanthom/DirtyJTAG/blob/master/src/cmd.c#L179
- Patch Set #7, Line 212: NULL
  Should use the `djtag_data->libusb_ctx`. Many more below, too.
  Done
- Patch Set #7, Line 297: return -1;
  Sorry, I always forget to check such cleanup paths ._. […]
```
Don't worry, I should've been more careful on this one. I've created 2 additionals labels for the cleanup path:
 * cleanup_djtag_struct: Freeing the djtag_data structure
 * cleanup_libusb_ctx: Cleaning the libusb context
 * cleanup_libusb_handle: Cleaning the libusb handle/attaching back the kernel driver
```

To view, visit change 67878. To unsubscribe, or for help writing mail filters, visit settings.