Ryan O'Leary has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/36946 )
Change subject: Fix a handful of compiler warnings ......................................................................
Patch Set 2:
(1 comment)
Patch Set 1:
(1 comment)
Thanks for taking care of this. Please, whenever fixing warnings that aren't enabled yet, also add a commit on top that enables them :)
Thanks! I found out the environment I was building under had set CC=clang which explains the difference in warnings. I've double checked there are no warnings under gcc or clang.
https://review.coreboot.org/c/flashrom/+/36946/1/libflashrom.c File libflashrom.c:
https://review.coreboot.org/c/flashrom/+/36946/1/libflashrom.c@192 PS1, Line 192: (enum flashrom_test_state)binfo[i].working;
IMHO, it would be better to use `enum flashrom_test_state` everywhere. That […]
Done. I added some defines for OK, BAD, etc.., otherwise it would be very verbose.