Patch Set 1:

(1 comment)

Thanks for taking care of this. Please, whenever fixing warnings
that aren't enabled yet, also add a commit on top that enables
them :)

Thanks! I found out the environment I was building under had set CC=clang which explains the difference in warnings. I've double checked there are no warnings under gcc or clang.

View Change

1 comment:

• File libflashrom.c:

  • Patch Set #1, Line 192: (enum flashrom_test_state)binfo[i].working;

    IMHO, it would be better to use `enum flashrom_test_state` everywhere. That […]

    Done. I added some defines for OK, BAD, etc.., otherwise it would be very verbose.

To view, visit change 36946. To unsubscribe, or for help writing mail filters, visit settings.