Attention is currently required from: Felix Singer, Thomas Heijligen, Edward O'Callaghan, Anastasia Klimchuk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67476 )
Change subject: flashrom.c: Embed is_internal state within the flashctx
......................................................................
Patch Set 2:
(2 comments)
File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/67476/comment/75366f3c_303e640b
PS2, Line 1007: fill_flash->is_internal = prog->is_internal;
self check Q: what about libflashrom
File include/programmer.h:
https://review.coreboot.org/c/flashrom/+/67476/comment/b40e4df9_3606c0bf
PS2, Line 50: bool is_internal;
perhaps a better idea is for this state to be part of the programmer parameters struct and for a programmer to be 'configured' as internal instead. Due to the control flow this somehow still needs to wind up in the flashctx that is being worked with?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/67476
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I25717afc3a8f61ca9f4dfb4bb60d6cb048a2ad37
Gerrit-Change-Number: 67476
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Mon, 10 Oct 2022 08:46:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
