Attention is currently required from: Felix Singer, Thomas Heijligen, Edward O'Callaghan, Anastasia Klimchuk.

View Change

2 comments:

• File cli_classic.c:

  • Patch Set #2, Line 1007: fill_flash->is_internal = prog->is_internal;

    self check Q: what about libflashrom

• File include/programmer.h:

  • Patch Set #2, Line 50: bool is_internal;

    perhaps a better idea is for this state to be part of the programmer parameters struct and for a programmer to be 'configured' as internal instead. Due to the control flow this somehow still needs to wind up in the flashctx that is being worked with?

To view, visit change 67476. To unsubscribe, or for help writing mail filters, visit settings.