Attention is currently required from: Edward O'Callaghan, Angel Pons, Arthur Heymans.
Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47166 )
Change subject: flaschips.c: Fix building with CONFIG_DUMMY=no
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/47166/comment/3ee0683c_0ce1ec8c
PS1, Line 9: is
: definition
is *no* definition
Done
Patchset:
PS3:
Saw this waiting around in my gerrit dashboard, decided to resolve comments.
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/47166/comment/8962e73a_c51d198d
PS1, Line 19086: int probe_variable_size(struct flashctx *flash) { return 0; };
declaration is in chipdrivers. […]
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/47166
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib9bae93fadc55cf133e837e63419da104a6298be
Gerrit-Change-Number: 47166
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Thu, 19 May 2022 20:50:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment