Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Nikolai Artemiev. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57973 )
Change subject: raiden_debug_spi: Use spi data in configure_protocol ......................................................................
Patch Set 2:
(2 comments)
File raiden_debug_spi.c:
https://review.coreboot.org/c/flashrom/+/57973/comment/0cad7b61_9282a110 PS1, Line 1599: spi_config->data = data; /* data is needed to configure protocol below */
Maybe worth to mention in the commit message, that this is not […]
This line was here for configure_protocol, because it needs both data and spi_config. But it was inconsistent with other spi masters and confusing. Confusing because the same line had been removed from all the other spi masters, and left here, just for configure_protocol. I was waiting for a chance to remove this line, and finally I can! :) I updated commit message, added more info.
https://review.coreboot.org/c/flashrom/+/57973/comment/708b21a5_d18e1ef3 PS1, Line 1327: struct raiden_debug_spi_data *ctx_data = : (struct raiden_debug_spi_data *)data;
No cast necessary, it already has that type. Or... […]
That's a good idea, renamed parameter ctx_data.