Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Nikolai Artemiev.

View Change

2 comments:

• File raiden_debug_spi.c:

  • Patch Set #1, Line 1599: spi_config->data = data; /* data is needed to configure protocol below */

    Maybe worth to mention in the commit message, that this is not […]

    This line was here for configure_protocol, because it needs both data and spi_config. But it was inconsistent with other spi masters and confusing. Confusing because the same line had been removed from all the other spi masters, and left here, just for configure_protocol. I was waiting for a chance to remove this line, and finally I can! :)
    I updated commit message, added more info.

  • Patch Set #1, Line 1327:

    struct raiden_debug_spi_data *ctx_data =
    		(struct raiden_debug_spi_data *)data;
    

    No cast necessary, it already has that type. Or... […]

    That's a good idea, renamed parameter ctx_data.

To view, visit change 57973. To unsubscribe, or for help writing mail filters, visit settings.