Attention is currently required from: Hsuan Ting Chen, Hsuan-ting Chen, Sam McNally, Subrata Banik.
Anastasia Klimchuk has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/flashrom/+/83144?usp=email )
Change subject: ichspi: Add support for Panther Lake ......................................................................
Patch Set 3:
(4 comments)
Patchset:
PS3: I think I asked everything I wanted. Hsuan-ting, Sam, do you have other comments, what do you think?
Commit Message:
https://review.coreboot.org/c/flashrom/+/83144/comment/8b507edc_9465a3ba?usp... : PS2, Line 9: Panther Lake
Acknowledged
Newbie question, how do I find the doc? :) I tried go to intel.com and search for doc number, no luck. I also tried to search by "panther lake".
File include/programmer.h:
https://review.coreboot.org/c/flashrom/+/83144/comment/21c19563_3744ae18?usp... : PS1, Line 364: /* All chipsets after METEOR_LAKE should support checking BIOS_BM to get read/write access to of FREG0~15 */
I think what Hsuan-ting meant to say (but correct me if I am wrong), is that we have 100 places in […]
Ah, I was thinking about consistent order more from readability point of view, not from execution of code point of view.
In any case, it won't be for this commit.
Hsuan-ting, since you started the thread, are you alright with the resolution?
File util/ich_descriptors_tool/ich_descriptors_tool.c:
https://review.coreboot.org/c/flashrom/+/83144/comment/0bb9b5a1_e0e9a8df?usp... : PS2, Line 251: else if (strcmp(csn, "panther") == 0) : cs = CHIPSET_PANTHER_LAKE;
I think the ich_descriptor_tool is run separately from flashrom. […]
Thanks!