Attention is currently required from: Hsuan Ting Chen, Hsuan-ting Chen, Sam McNally, Subrata Banik.
4 comments:
Patchset:
I think I asked everything I wanted.
Hsuan-ting, Sam, do you have other comments, what do you think?
Commit Message:
Patch Set #2, Line 9: Panther Lake
Acknowledged
Newbie question, how do I find the doc? :) I tried go to intel.com and search for doc number, no luck. I also tried to search by "panther lake".
File include/programmer.h:
Patch Set #1, Line 364: /* All chipsets after METEOR_LAKE should support checking BIOS_BM to get read/write access to of FREG0~15 */
> I think what Hsuan-ting meant to say (but correct me if I am wrong), is that we have 100 places in […]
Ah, I was thinking about consistent order more from readability point of view, not from execution of code point of view.
In any case, it won't be for this commit.
Hsuan-ting, since you started the thread, are you alright with the resolution?
File util/ich_descriptors_tool/ich_descriptors_tool.c:
else if (strcmp(csn, "panther") == 0)
cs = CHIPSET_PANTHER_LAKE;
> I think the ich_descriptor_tool is run separately from flashrom. […]
Thanks!
To view, visit change 83144. To unsubscribe, or for help writing mail filters, visit settings.