Attention is currently required from: ChrisEric1 CECL, Edward O'Callaghan, Nicholas Chin.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72057 )
Change subject: Add support for VIA VL805 USB Controller flashing ......................................................................
Patch Set 15:
(5 comments)
Patchset:
PS15: One or two more rounds and we are good to go
File vl805.c:
https://review.coreboot.org/c/flashrom/+/72057/comment/33746cd0_16fbaaa1 PS15, Line 43:
"No, as this is just a type declaration and thus static doesn't have an effect […]
Correct
https://review.coreboot.org/c/flashrom/+/72057/comment/882dd457_43e2b8fb PS15, Line 154: msg_pdbg("VL805 firmware version 0x%08x\n", val); On some compilers we have problems with printing fixed size integers. So we must use the macros from `inttypes.h` Replace the line with: ``` msg_pdbg("VL805 firmware version %#08"PRIx32"\n", val) ``` and we are fine.
https://review.coreboot.org/c/flashrom/+/72057/comment/af3c1a5a_99460a1e PS15, Line 175: register_spi_master(&spi_master_vl805, dev); This `register_master` musst be removed.
https://review.coreboot.org/c/flashrom/+/72057/comment/9406e660_13d61b38 PS15, Line 177: return 0; return the result of register_spi_master()
``` data->dev = dev; return register_spi_master(&spi_master_vl805, data); } ```