Attention is currently required from: ChrisEric1 CECL, Edward O'Callaghan, Nicholas Chin.

View Change

5 comments:

• Patchset:

  • Patch Set #15:

    One or two more rounds and we are good to go

• File vl805.c:

  • Patch Set #15, Line 43:

    "No, as this is just a type declaration and thus static doesn't have an effect […]

    Correct

  • Patch Set #15, Line 154: msg_pdbg("VL805 firmware version 0x%08x\n", val);

    On some compilers we have problems with printing fixed size integers. So we must use the macros from `inttypes.h` Replace the line with:
    ```
    msg_pdbg("VL805 firmware version %#08"PRIx32"\n", val)
    ```
    and we are fine.

  • Patch Set #15, Line 175: register_spi_master(&spi_master_vl805, dev);

    This `register_master` musst be removed.

  • Patch Set #15, Line 177: return 0;

    return the result of register_spi_master()

    ```
      data->dev = dev;
      return register_spi_master(&spi_master_vl805, data);
    }
    ```

To view, visit change 72057. To unsubscribe, or for help writing mail filters, visit settings.