Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/43140 )
Change subject: Makefile: Fix building on AArch64 NixOS ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/c/flashrom/+/43140/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/43140/1//COMMIT_MSG@8 PS1, Line 8:
The problem was originally described and resolved here: https://github. […]
You don't need to force-push, but pushing an amended commit to gerrit with the same Change-Id line will become a new "patchset" (version) of this change.
https://review.coreboot.org/c/flashrom/+/43140/1/Makefile File Makefile:
https://review.coreboot.org/c/flashrom/+/43140/1/Makefile@110 PS1, Line 110: grep '"' As mentioned on the GitHub issue, I'd prefer to improve the parsing step. Start by ignoring lines with "__attribute__", and maybe add a check with "wc" to exit early if more than one word is detected?