Patch set 1:Code-Review +1

View Change

2 comments:

• Commit Message:

  • Patch Set #1, Line 8:

    The problem was originally described and resolved here: https://github. […]

    You don't need to force-push, but pushing an amended commit to gerrit with the same Change-Id line will become a new "patchset" (version) of this change.

• File Makefile:

  • Patch Set #1, Line 110: grep '"'

    As mentioned on the GitHub issue, I'd prefer to improve the parsing step. Start by ignoring lines with "__attribute__", and maybe add a check with "wc" to exit early if more than one word is detected?

To view, visit change 43140. To unsubscribe, or for help writing mail filters, visit settings.